This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix wrong common symbol size in LTO symtabs.

From: Dave Korn <dave dot korn dot cygwin at gmail dot com>
To: Richard Henderson <rth at redhat dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Tue, 09 Nov 2010 22:30:49 +0000
Subject: Re: [PATCH] Fix wrong common symbol size in LTO symtabs.
References: <4CD9BFE1.20703@gmail.com> <4CD9BD91.1090404@redhat.com> <4CD9C5BE.7020506@gmail.com> <4CD9C17A.7080502@redhat.com> <4CD9C86F.1040602@gmail.com> <4CD9C3E6.90906@redhat.com>

On 09/11/2010 21:57, Richard Henderson wrote:
> On 11/09/2010 02:17 PM, Dave Korn wrote:
>>   I can't just replace the "<< 32" with "<< sizeof HWI"?
> 
> No, because if HWI = int64_t, you'll be shifting larger
> than the integer size.

  But the LHS is already being cast to uint_64_t before the shift is applied,
unless my eyes have misread the bracket nesting.  I thought it's only wrong to
shift larger than the LHS size, or is there some portability issue with that?

    cheers,
      DaveK

References:
- [PATCH] Fix wrong common symbol size in LTO symtabs.
  - From: Dave Korn
- Re: [PATCH] Fix wrong common symbol size in LTO symtabs.
  - From: Richard Henderson
- Re: [PATCH] Fix wrong common symbol size in LTO symtabs.
  - From: Dave Korn
- Re: [PATCH] Fix wrong common symbol size in LTO symtabs.
  - From: Richard Henderson
- Re: [PATCH] Fix wrong common symbol size in LTO symtabs.
  - From: Dave Korn
- Re: [PATCH] Fix wrong common symbol size in LTO symtabs.
  - From: Richard Henderson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]