This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] Add gcc-ar, gcc-ranlib, gcc-ld wrappers


Andi Kleen <ak@linux.intel.com> writes:

> On Fri, Oct 29, 2010 at 01:31:31PM +0000, Joseph S. Myers wrote:
>> On Fri, 29 Oct 2010, Andi Kleen wrote:
>> > +if test "x$R" != "x" ; then
>> > +	# work around gold bug, -r and -fuse-linker-plugin
>> > +	# do not interact well. It's not needed anyways.
>> > +	# the gold bug has been fixed, but still keep this.
>> > +	ARGS=`echo $ARGS | sed -e s/-fuse-linker-plugin//`
>> 
>> Apart from the issues with spaces, echo will process some options on some 
>> systems and this sed command will happily modify option arguments that 
>> happen to contain that particular string.  As before, (POSIX) shell is not 
>> a good language in which to do this robustly (if you e.g. assume various 
>> bash features, it becomes easier).
>
> Are these systems with funny echo supported by LTO?

You can do that without echo.

Andreas.

-- 
Andreas Schwab, schwab@redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84  5EC7 45C6 250E 6F00 984E
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]