This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Fix split_stack_return
On Wed, Oct 27, 2010 at 7:10 AM, Ian Lance Taylor <iant@google.com> wrote:
> "H.J. Lu" <hjl.tools@gmail.com> writes:
>
>> On Wed, Oct 27, 2010 at 6:15 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> On Tue, Oct 26, 2010 at 7:38 PM, Ian Lance Taylor <iant@google.com> wrote:
>>>> "H.J. Lu" <hjl.tools@gmail.com> writes:
>>>>
>>>>> I found the problem when I am working on my vzeroupper change.
>>>>> The bad "split_stack_return" pattern makes it impossible for me
>>>>> to work on vzeroupper since gcc kept generating "ret $2"
>>>>> for my vzeroupper pattern. The split_stack_return issue wasted
>>>>> my time and blocked my vzeroupper change, which I want to finish during
>>>>> gcc summit. That is why I committed my change.
>>>>
>>>> I'm sorry for blocking your change. ?Still, we have an approval system
>>>> for a reason.
>>>>
>>>> Does this patch fix your problem?
>>>>
>>>
>>> I opened a bug:
>>>
>>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46197
>>>
>>> Ian, could you please took into it? Right now, "gcc -mavx -O3" generates
>>> garbage.
>>>
>>
>> I checked in this patch.
>
> OK I suppose, but, seriously: please do wait for approval. ?The system
> doesn't work when people just commit patches themselves.
>
Without the fix, "gcc -mavx -O3" generates garbage. That change only affects
-fsplit-stack. Even if it isn't completely correct, at least it won't
generate garbage.
--
H.J.