This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, c* ,ObjC*] handle string objects in format checking.
Hello Joseph,
On 24 Oct 2010, at 16:27, Joseph S. Myers wrote:
On Sun, 24 Oct 2010, IainS wrote:
You're adding a new format style, "NSString". There's no
documentation
for what it means,
NSString is documented in the relevant Objective C documentation.
- should I add a cross-reference here ?
or simply state what it is?
The Objective C documentation describes
__attribute__((__format__(NSString,1,2))) or similar?
no, whilst it does discuss attribute markup, it does not give such a
format example.
I'll add something to the gcc doc.
no testcases for this format style checking,
the tests are already present (in test-cases that currently fail
for NeXT
ObjC).
What testcases? Please give specific file names of tests in the GCC
testsuite that FAIL before this patch, PASS afterwards, and use the
sort
of format attribute construct I mention above.
on Darwin10, any test-case that includes <Foundation/Foundation.h>
or anything that includes (indirectly usually) CFString.h
for example;
gcc/testsuite/objc.dg/no-extra-load.m:#import <Foundation/Foundation.h>
gcc/testsuite/objc.dg/objc-foreach-4.m:#include <Foundation/
Foundation.h>
gcc/testsuite/objc.dg/objc-foreach-5.m:#import <Foundation/Foundation.h>
but, of course, I am happy to improve test coverage - I have one or
two stand-alone tests in my local test directory that could be used.
At present, this is all darwin-specific, although Nicola might wish to
extend to GNUstep, the consensus was probably not during 4.6.
I'll wait for any further comments,
and for Mike's input and then update the patch.
thanks.
Iain
--
Joseph S. Myers
joseph@codesourcery.com