This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] make ifcvt try harder to use conditional moves
On Wed, Oct 20, 2010 at 07:53:22PM +0200, Eric Botcazou wrote:
> > * ifcvt.c (noce_emit_cmove): If both of the values are SUBREGs, try
> > emitting the conditional move in the inner mode of the SUBREG.
>
> OK for mainline, modulo:
>
> > + If we can't create new pseudos, though, don't bother. */
> > + if (!can_create_pseudo_p ())
> > + return NULL_RTX;
>
> Write "if (reload_completed)" for the sake of consistency; no need to retest.
I did this, but am confused: we have this handy macro in rtl.h for such
testing; why not use it in this case? I thought the use of the macro
was preferred.
-Nathan