This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Add fma support to the middle end and powerpc
On 10/14/2010 04:52 PM, Michael Meissner wrote:
> On Thu, Oct 14, 2010 at 12:03:24PM -0700, Richard Henderson wrote:
>> On 10/14/2010 11:00 AM, Michael Meissner wrote:
>>> On Thu, Oct 14, 2010 at 07:57:50AM -0700, Richard Henderson wrote:
>>>> Frankly I don't see what's so holy about c-cppbuiltin that it can't
>>>> have access to tm.h.
>>>
>>> I dunno, there seemed to be a desire to remove the rtl stuff from the front
>>> ends.
>>
>> Would the objecting party please step forward?
>>
>> Because I'd like to argue that c-cppbuiltin.c having access to insn-flags.h
>> in order to set FMA_FAST is no different than what it currently done with
>> TARGET_FLT_EVAL_METHOD, or for that matter any of the FLT* or DBL* defines.
>
> Here is the patch redone so that any port that defines the appropriate
> fma<mode>4 rtl constructs gets the __FP_FAST_FMA{,F,L} defined. I fixed
> simplify-rtx.c to return NULL_RTX instead of 0. I deleted the changes to
> REVISION that I forgot to delete for the patch.
>
> I redid the bootstrap with no problems, and did not notice any regressions in
> the test suite. Is this ok to check in?
Ok. Thanks for your patience.
r~