This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH,take2] Make LTO plugin object-file-format- and host- independent.
- From: Richard Henderson <rth at redhat dot com>
- To: Dave Korn <dave dot korn dot cygwin at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 06 Oct 2010 11:33:32 -0700
- Subject: Re: [PATCH,take2] Make LTO plugin object-file-format- and host- independent.
- References: <4CAC37E8.9060504@gmail.com>
> + # ELF platforms build the lto-plugin when GOLD is in use.
> + build_lto_plugin=${ENABLE_GOLD}
I won't hold up your patch based on it, but I'd like to not
tie build_lto_plugin to gold even for elf. Your gnu-ld patch
should enable lto for the elf targets that havn't been ported
to gold.
> +++ lto-plugin/lto-plugin.h (revision 0)
As a future enhancement, it's probably worth wrapping most of
this file in
#ifdef HAVE_ATTRIBUTE_VISIBILITY
# pragma GCC visibility push(hidden)
#endif
...
#ifdef HAVE_ATTRIBUTE_VISIBILITY
# pragma GCC visibility pop
#endif
See libgomp for configure bits.
It looks as if you've addressed the rest of the configuration
feedback you received in v1.
Patch is ok.
r~