This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [PATCH] Report LTO phase in lto1 process name v2


On 10/6/2010 7:48 PM, DJ Delorie wrote:
+/* Set the title of a process */
+extern void setproctitle (const char *name, ...);
Do we really want to add another global namespace-colliding name here?
We've used l_* before, how about l_setproctitle() ?

That was intentional; the idea was that it fall back to the BSD libc version like
the other libiberty fallback functions (that was one of the feedbacks for v1)



-/* Define to 1 if you have the declaration of `basename', and to 0 if you
-   don't. */
+/* Define to 1 if you have the declaration of `basename(char *)', and to 0 if
+   you don't. */
  #undef HAVE_DECL_BASENAME
Please double-check that you're using the right versions of all the
tools to regenerate these with.

I believe I do, but the file was stale that is why I got these additional changes.


-Andi


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]