This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Fix ICE (PR Tree-Vect/45847).
- From: Richard Guenther <richard dot guenther at gmail dot com>
- To: Tejas Belagod <tejas dot belagod at arm dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 5 Oct 2010 15:51:44 +0200
- Subject: Re: [Patch] Fix ICE (PR Tree-Vect/45847).
- References: <1286284825.22296.74.camel@e102484-lin.cambridge.arm.com>
On Tue, Oct 5, 2010 at 3:20 PM, Tejas Belagod <tejas.belagod@arm.com> wrote:
> Hi,
>
> The attached patch fixes Bugzilla 45847
> (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45847). When compiling
> without -mvectorize-with-neon-quad and vectorizing scalar widening
> operations that widen words to double words, there are no corresponding
> vector types for DI scalar types. For this scenario, a call to
> get_vect_type_for_scalar_type() returns NULL and an absent NULL-check
> caused this segfault. The attached patch adds this NULL-check. Also,
> this is consistent with all the other places where a NULL-check follows
> a call to get_vect_type_for_scalar_type() in tree-vect-patterns.c.
>
> Regression tested with arm-linux-gnueabi. OK?
Ok.
Thanks,
Richard.
> --
> Tejas Belagod
> ARM.
>
> gcc/
>
> 2010-10-05 ?Tejas Belagod ?<tejas.belagod@arm.com>
>
> ? ? ? ?* tree-vect-patterns.c (vect_recog_widen_mult_pattern): Add NULL
> ? ? ? ?check for vectype_out returned by get_vectype_for_scalar_type().
>
> testsuite/
>
> 2010-10-05 ?Tejas Belagod ?<tejas.belagod@arm.com>
>
> ? ? ? ?* gcc.dg/vect/pr45847.c: New test.
>