This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, fortran] Further dependency improvements


Thomas Koenig wrote:
Hello world,

now I'm back from my holiday, here is another round of dependency
improvements.  This patch is fairly self-explanatory.

OK for trunk?

Hi Thomas,


not a review but just a small comment:

+	      /* List of intrinsic functions with side effects or which
+		 may compare unequal for equal arguments.  */
+	    case GFC_ISYM_CHDIR:
+	    case GFC_ISYM_CHMOD:
+	    case GFC_ISYM_DTIME:
+	    case GFC_ISYM_ETIME:
+	    case GFC_ISYM_FDATE:
+	    case GFC_ISYM_FGET:
+	    case GFC_ISYM_FGETC:
+	    case GFC_ISYM_FNUM:
+	    case GFC_ISYM_FPUT:
...

I think that we introduced CLASS_PURE / CLASS_IMPURE for intrinsics lately -- and would suggest to use that information instead of duplicating the list here. Although I do not completely remember whether that is already set correctly or not.

Daniel

--
http://www.pro-vegan.info/
--
Done:  Arc-Bar-Cav-Kni-Ran-Rog-Sam-Tou-Val-Wiz
To go: Hea-Mon-Pri


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]