This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, C++] PR43824 pedantic with inline namespaces


On 08/24/2010 06:56 AM, Rodrigo Rivas wrote:
	PR c++/43824
	* g++.dg/lookup/strong-using-1.C: Set dg-options to "" to avoid
	the -pedantic errors.

"Why" information like "to avoid the -pedantic errors" belongs in comments in the code; the ChangeLog entry should only describe the change.


Other than that, this looks ready to go in once your copyright assignment is complete.

Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]