This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, C++] PR43824 pedantic with inline namespaces

From: Jason Merrill <jason at redhat dot com>
To: Rodrigo Rivas <rodrigorivascosta at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Tue, 24 Aug 2010 22:26:08 -0700
Subject: Re: [PATCH, C++] PR43824 pedantic with inline namespaces
References: <1280185724.5689.2.camel@abajo> <4C6C5BD8.30606@redhat.com> <AANLkTi=a4CZwY+F7-NKO4mdVOT10aVdG2jmaYs40MoTh@mail.gmail.com> <4C735352.3020804@redhat.com> <AANLkTinxPKd7r6tH4QJzJhvDoK+xy4H0Ev6ry_0BX_5K@mail.gmail.com>

On 08/24/2010 06:56 AM, Rodrigo Rivas wrote:

	PR c++/43824
	* g++.dg/lookup/strong-using-1.C: Set dg-options to "" to avoid
	the -pedantic errors.

"Why" information like "to avoid the -pedantic errors" belongs in comments in the code; the ChangeLog entry should only describe the change.

Other than that, this looks ready to go in once your copyright assignment is complete.

Jason

References:
- Re: [PATCH, C++] PR43824 pedantic with inline namespaces
  - From: Jason Merrill
- Re: [PATCH, C++] PR43824 pedantic with inline namespaces
  - From: Rodrigo Rivas
- Re: [PATCH, C++] PR43824 pedantic with inline namespaces
  - From: Jason Merrill
- Re: [PATCH, C++] PR43824 pedantic with inline namespaces
  - From: Rodrigo Rivas

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]