This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Combine four insns


On 10-08-19 20:22 , Mark Mitchell wrote:

I don't want to see it get too procedural to get something checked in.
I'd rather have a culture where it's not too hard to get things in, but
where we are responsive to problems raised after the patch is checked
in.

Agreed. I'm not very concerned about getting patches in that may break something, even if it may not be immediately obvious at the time. I would much rather roll patches back instead of agonizing that every last bit of a given patch meets some impossible standard of perfection.


I do not have an opinion on this particular patch as I have not followed this thread closely enough. I just wanted to offer my vote about making patch acceptance as painless as possible. There is sufficient testing spread around, that detecting bad commits is rarely the problem.


Diego.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]