This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch c++]: Make structure in exten C block and for -fms-extension more permissive.
2010/8/17 Jason Merrill <jason@redhat.com>:
> On 08/16/2010 04:48 PM, Kai Tietz wrote:
>>
>> + ? For records in external C blocks allow member-names even to types,
>> + ? if pedantic isn't set. ?*/
>
> This comment should be by the new code, not at the top of the function. ?And
> it should be clearer, like 'C allows members to be declared with a type of
> the same name, and the C++ standard says this diagnostic is not required, so
> allow it in extern "C" blocks unless pedantic. ?Allow it in all cases if
> -fms-extensions.'
>
>> +It allows for c++ that member-names in structures can be similiar
>> +to previous types declarations.
>
> "Allows class members to be declared with a type of the same name."
>
> Lets add one more test for the pedantic case.
>
> OK with those changes.
>
> Jason
>
Ok, modified as you suggested and added a fourth test-case for
-pedantic. Applied at revision 163298, 163300, and 163301.
Regards,
Kai
--
|? (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination