This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, C] Fix PR40563

From: Shujing Zhao <pearly dot zhao at oracle dot com>
To: "Joseph S. Myers" <joseph at codesourcery dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Paolo Carlini <paolo dot carlini at oracle dot com>
Date: Tue, 17 Aug 2010 16:31:08 +0800
Subject: Re: [PATCH, C] Fix PR40563
References: <4C4664DB.6040902@oracle.com> <Pine.LNX.4.64.1007271354460.8014@digraph.polyomino.org.uk> <4C4FEC69.3090600@oracle.com> <AANLkTimETNFpNy=zkJO1+COjQnK87pS2NLG82V8wwYsx@mail.gmail.com> <4C52A23B.6010408@oracle.com> <Pine.LNX.4.64.1008131701530.7859@digraph.polyomino.org.uk>

On 08/14/2010 01:02 AM, Joseph S. Myers wrote:

On Fri, 30 Jul 2010, Shujing Zhao wrote:

OK. Clear the comment of diagnose_uninitialized_cst_member.
C_TYPE_FIELDS_READONLY is used before recursing the struct or union.
Uninitialized array of structures would be diagnosed if one of members is
const.
The warned type is changed to "strip_array_types (TREE_TYPE (decl)", so that
it would warn struct or union type, not the array.

The testcase is fixed to test the recursing and test the array of structure
that has const member.

Tested on trunk and bootstraped.
Is it ok?

This patch is OK.

Retested on current trunk and committed revision 163296. Thanks

Pearly

References:
- Re: [PATCH, C] Fix PR40563
  - From: Joseph S. Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]