This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] enable omit-frame-pointer on darwin with dwarf2


On Fri, Aug 13, 2010 at 9:09 AM, Jack Howarth <howarth@bromo.med.uc.edu> wrote:
> On Fri, Aug 13, 2010 at 08:59:50AM -0700, H.J. Lu wrote:
>> On Fri, Aug 13, 2010 at 2:56 AM, Jack Howarth <howarth@bromo.med.uc.edu> wrote:
>> > The attached patch enables -fomit-frame-pointer for those darwin
>> > releases which support dwarf2. Bootstrapped and regression tested
>> > on x86_64-apple-darwin10. Okay for gcc trunk?
>> > ? ? ? ? ? ? ? ? Jack
>> >
>> > 2010-08-12 ?Jack Howarth <howarth@bromo.med.uc.edu>
>> >
>> > ? ? ? ?* gcc/configure.ac: Enable -fomit-frame-pointer on darwin
>> > ? ? ? ?which support dwarf2.
>> > ? ? ? ?* config/i386/i386.c (override_options): Same.
>> >
>> >
>> > Index: gcc/configure.ac
>> > ===================================================================
>> > --- gcc/configure.ac ? ?(revision 163214)
>> > +++ gcc/configure.ac ? ?(working copy)
>> > @@ -1584,7 +1584,7 @@
>> > ?[ ?--enable-frame-pointer ?enable -fno-omit-frame-pointer by default for 32bit x86], [],
>> > ?[
>> > ?case $target_os in
>> > -linux*)
>> > +linux* | darwin[[8912]]*)
>>
>> This will match darwin8*, darwin9*, darwin1*, darwin2*. Is this what you want?
>
> Yes. The idea is to enable -fomit-frame-pointer on all darwin releases
> which support dwarf2. It could have been simplier if we had already
> depreciated out support for darwin7 (which only supports stabs) but
> I haven't gotten around to that yet.
>
>>
>> > ? # Enable -fomit-frame-pointer by default for Linux.
>
> Can you just change that to
>
> ?? # Enable -fomit-frame-pointer by default for Linux and Darwin with dwarf2.
>
> or do I need to recreate the patch?
>

I will take care of it.


-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]