This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] don't use chainon when building VMS descriptors in Ada FE
- From: Nathan Froyd <froydnj at codesourcery dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sun, 8 Aug 2010 18:07:06 -0700
- Subject: Re: [PATCH] don't use chainon when building VMS descriptors in Ada FE
- References: <20100713194905.GK12333@codesourcery.com> <201007201936.43146.ebotcazou@adacore.com> <20100807165928.GF17362@codesourcery.com> <201008090050.17413.ebotcazou@adacore.com>
On Mon, Aug 09, 2010 at 12:50:17AM +0200, Eric Botcazou wrote:
> > * gcc-interface/utils.c (make_descriptor_field): Add tree
> > parameter.
> > (build_vms_descriptor32): Adjust calls to it for new parameter.
> > (build_vms_descriptor): Likewise.
>
> OK if you rename the new parameter of make_descriptor_field into FIELD_LIST
> and document it in the head comment of the function.
Thanks. This is the comment I committed.
/* Utility routine for above code to make a field. FIELD_LIST is the
list of decls being built; the new decl is chained on to the front of
the list. */
-Nathan