This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix ARM ldm/stm peephole2 loop


On Thu, 2010-08-05 at 03:09 +0200, Bernd Schmidt wrote:
> With -mtune=xscale, arm_gen_load_multiple_1 doesn't actually generate a
> load-multiple for two loads, but single instructions.  This causes a
> peephole2 loop where we try to optimize the same instructions over and
> over again.
> 
> Fixed by teaching multiple_operation_profitable_p about this situation.  Ok?
> 
> 
> Bernd

+  if (nops <= 2 && arm_tune_xscale && !optimize_size)

It seems wrong to me to have an explicit test for XScale here.  Other
cores could surely exist that result in a similar loop.  Ie the test
should be on the cause, not on 'it's an xscale'

R



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]