This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, fortran] Follow references in dependency checking
- From: Thomas Koenig <tkoenig at netcologne dot de>
- To: Tobias Burnus <tobias dot burnus at physik dot fu-berlin dot de>
- Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
- Date: Mon, 02 Aug 2010 18:55:08 +0200
- Subject: Re: [patch, fortran] Follow references in dependency checking
- References: <20100802063509.GA9307@physik.fu-berlin.de>
Am Montag, den 02.08.2010, 08:35 +0200 schrieb Tobias Burnus:
> Thomas Koenig wrote:
> > > + while ((numref = (r1 != NULL) + (r2 != NULL)) > 0)
> > > + {
> > > +
> > > +
> > > That's ugly. Can't you simply use the following?
> >
> > Changed to something more becoming. You were right that this was
> > ugly :-)
>
> Thanks. Can you also remove the - now obsolete - comment, which
> explains the different values of "numref"?
Done.
> > Currently regtesting. OK if this passes?
>
> OK. Thanks for the patch!
Sending fortran/ChangeLog
Sending fortran/dependency.c
Sending fortran/dependency.h
Sending fortran/frontend-passes.c
Sending testsuite/ChangeLog
Adding testsuite/gfortran.dg/character_comparison_2.f90
Adding testsuite/gfortran.dg/character_comparison_3.f90
Adding testsuite/gfortran.dg/dependency_28.f90
Transmitting file data ........
Committed revision 162824.
Thanks for the review!
Thomas