This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix memory corruption in LTO
- From: Richard Guenther <rguenther at suse dot de>
- To: Jan Hubicka <hubicka at ucw dot cz>
- Cc: ak at linux dot intel dot com, gcc-patches at gcc dot gnu dot org
- Date: Tue, 27 Jul 2010 10:30:49 +0200 (CEST)
- Subject: Re: Fix memory corruption in LTO
- References: <20100726192415.GC20984@kam.mff.cuni.cz>
On Mon, 26 Jul 2010, Jan Hubicka wrote:
> Hi,
> Andi's changes introduced heap allocated object pointed from lto_file_data, so
> we now ICE on everything big enough to trigger garbage collector at WPA stage.
> Andi: this solves the cgraph hash table ICE you sent me
>
> Bootstrapping/regtesting x86_64-linux, OK?
Ok.
Thanks,
Richard.
> Honza
>
> * lto-streamer.h (struct lto_file_decl_data): Mark resolutions with GTY((skip))
> Index: lto-streamer.h
> ===================================================================
> --- lto-streamer.h (revision 162539)
> +++ lto-streamer.h (working copy)
> @@ -602,13 +602,13 @@
> htab_t GTY((skip)) renaming_hash_table;
>
> /* Linked list used temporarily in reader */
> struct lto_file_decl_data *next;
>
> /* Sub ID for merged objects. */
> unsigned id;
>
> /* Symbol resolutions for this file */
> - VEC(ld_plugin_symbol_resolution_t,heap) *resolutions;
> + VEC(ld_plugin_symbol_resolution_t,heap) * GTY((skip)) resolutions;
> };
>
> typedef struct lto_file_decl_data *lto_file_decl_data_ptr;
>
>
--
Richard Guenther <rguenther@suse.de>
Novell / SUSE Labs
SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 - GF: Markus Rex