This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix memory corruption in LTO


> On 10-07-26 12:24 , Jan Hubicka wrote:
>> Hi,
>> Andi's changes introduced heap allocated object pointed from lto_file_data, so
>> we now ICE on everything big enough to trigger garbage collector at WPA stage.
>> Andi: this solves the cgraph hash table ICE you sent me
>>
>> Bootstrapping/regtesting x86_64-linux, OK?
>> Honza
>>
>> 	* lto-streamer.h (struct lto_file_decl_data): Mark resolutions with GTY((skip))
>
> Would it make more sense to change the allocation on the resolutions field?

Well, lto_file_decl_data has most of fields skipped anyway and I think it is
good idea as I don't like moving random stuff into garbage collector.  It is in
GGC because it points to global_decl_state that points to decls, but the
other streamer data are better to stay in explicitely allocated memory IMO.

Honza
>
>
> Diego.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]