This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch Darwin 2/2] fix PPC64 ABI

On Sat, Jul 24, 2010 at 12:43:52PM +0100, IainS wrote:
> On 24 Jul 2010, at 11:13, Nathan Froyd wrote:
>> Could we avoid introducing more #if TARGET_MACHO where it's not
>> necessary?  It should be sufficient to say something like:
>>      && rs6000_darwin_abi
>>      && integer_zerop (TYPE_SIZE (type)))
>>    ...
>> and the compiler will DTRT and fold out that code for non-Darwin
>> targets.  (This comment applies equally to your other darwin64 patch.)
> sure, if that's the preference, no problem.
> I guess I was thinking that it would be better to eliminate the code  at 
> pre-processing

It does slightly speed things up (I doubt that you'd notice the speedup,
really).  The rationale for using:




is that with the former, the compiler will validate that the code
syntax-checks and type-checks even when compiling for non-Darwin
targets.  This extra checking makes it slightly harder to inadvertently
break things.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]