This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix "naked" attribute (PR target/44290)


On 07/23/2010 10:29 PM, Mark Mitchell wrote:
Jie Zhang wrote:

But, I think the implementation could be more architecture-independent.
   I'm prepared to say that any architecture that supports the "naked"
attribute *must* implement it with the semantics on the architectures
you name above.  That means that the ${arch}_insert_attributes functions
you have could be architecture-independent.  Just put that code into the
architecture-independent attribute-processing function.

This is a good idea. The modified patch is attached. Is it OK now?

This patch is OK.


Thanks. I have committed the patch on trunk.

I thought a little bit about whether the manual should document
explicitly that naked functions will not be inlined (or cloned).  I
don't really think that's necessary, but if other people do, please
respond to such a request.

OK.


Regards, -- Jie Zhang CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]