This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Unreviewed^2 testsuite patches
On Fri, Jul 23, 2010 at 11:28:44AM +0200, Richard Guenther wrote:
> On Fri, Jul 23, 2010 at 10:34 AM, Rainer Orth
> <ro@cebitec.uni-bielefeld.de> wrote:
> > The following two patches have remained unreviewed for some time despite
> > a reminder:
> >
> > ? ? ? ?[build, doc, libjava, testsuite] Fully support TLS on Solaris 8 and 9
> > ? ? ? ?http://gcc.gnu.org/ml/gcc-patches/2010-07/msg01277.html
> >
> > Most of this patch is Solaris-specific, but I may need approval for the
> > testsuite parts. ?One might argue that they are obvious, though.
> >
> > ? ? ? ?[testsuite] Increase gcc.dg/pr43058.c timeout
> > ? ? ? ?http://gcc.gnu.org/ml/gcc-patches/2010-07/msg01162.html
> >
> > I'm going to install this as obvious soon (on the 4.5 branch only after
> > it reopens, of course).
>
> It builds in less than 60s for me, even with checking enabled and
> a compiler built with -O0. So - is your machine really so slow?
> Increasing the timeout will make us fail notice compile-time regressions
> here.
The test is more expensive on some targets, depending on what exact code is
generated for the calls. I guess some increase in the timeout is
reasonable.
I didn't want to make the test much smaller, because then even with the
var-tracking issue that was fixed in that patch it would often finish within
timeout, with this size it would already eat much longer.
So, timeout factor 4 is fine with me, but of course I can't approve that.
Jakub