This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Check AVX runtime support


Uros Bizjak <ubizjak@gmail.com> writes:

> Please note that compile tests don't need effective-target check.

Of course they do, to make sure that the assembler is capable of
assembling the compiler output (think Solaris 8/9 as).  We just don't
need both, say, sse2 and sse2_runtime with your patch, which is nice.

> Index: gcc.dg/pr34856.c
> ===================================================================
> --- gcc.dg/pr34856.c	(revision 162422)
> +++ gcc.dg/pr34856.c	(working copy)
> @@ -1,7 +1,6 @@
>  /* { dg-do compile } */
>  /* { dg-options "-O2" } */
>  /* { dg-options "-O2 -msse2" { target { i?86-*-* x86_64-*-* } } } */
> -/* { dg-require-effective-target sse2 { target { i?86-*-* x86_64-*-* } } } */
>  /* { dg-options "-O2 -maltivec" { target { powerpc*-*-linux* && powerpc_altivec_ok } } } */

Need to keep dg-require-effective-target sse2 here.

> Index: gcc.dg/20020418-1.c
> ===================================================================
> --- gcc.dg/20020418-1.c	(revision 162422)
> +++ gcc.dg/20020418-1.c	(working copy)
> @@ -2,7 +2,6 @@
>  /* { dg-do compile } */
>  /* { dg-options "-O2" } */
>  /* { dg-options "-O2 -msse -ffast-math" { target i?86-*-* x86_64-*-* } } */
> -/* { dg-require-effective-target sse { target i?86-*-* x86_64-*-* } } */
>  
>  void bar (float *a, float *b);

Same here.

> Index: gcc.dg/pr32176.c
> ===================================================================
> --- gcc.dg/pr32176.c	(revision 162422)
> +++ gcc.dg/pr32176.c	(working copy)
> @@ -3,7 +3,6 @@
>  /* { dg-do compile } */
>  /* { dg-options "-O2 -fprefetch-loop-arrays -w" } */
>  /* { dg-options "-O2 -fprefetch-loop-arrays -march=i686 -msse" { target { { i?86-*-* x86_64-*-* } && ilp32 } } } */
> -/* { dg-require-effective-target sse { target { { i?86-*-* x86_64-*-* } && ilp32 } } } */

... and here.

> Index: gcc.dg/prefetch-loop-arrays-1.c
> ===================================================================
> --- gcc.dg/prefetch-loop-arrays-1.c	(revision 162422)
> +++ gcc.dg/prefetch-loop-arrays-1.c	(working copy)
> @@ -2,7 +2,6 @@
>  /* { dg-do compile } */
>  /* { dg-options "-O2 -fprefetch-loop-arrays -w" } */
>  /* { dg-options "-O2 -fprefetch-loop-arrays -march=i686 -msse -w" { target { { i?86-*-* x86_64-*-* } && ilp32 } } } */
> -/* { dg-require-effective-target sse { target { { i?86-*-* x86_64-*-* } && ilp32 } } } */

Again.

> Index: gcc.dg/pr36997.c
> ===================================================================
> --- gcc.dg/pr36997.c	(revision 162422)
> +++ gcc.dg/pr36997.c	(working copy)
> @@ -1,6 +1,5 @@
>  /* { dg-do compile { target x86_64-*-* i?86-*-* } } */
>  /* { dg-options "-std=c99 -msse2" } */
> -/* { dg-require-effective-target sse2 } */

And again.

> Index: gfortran.dg/pr28158.f90
> ===================================================================
> --- gfortran.dg/pr28158.f90	(revision 162422)
> +++ gfortran.dg/pr28158.f90	(working copy)
> @@ -1,7 +1,6 @@
>  ! { dg-do compile { target i?86-*-* x86_64-*-* } }
>  ! { dg-require-effective-target ilp32 }
>  ! { dg-options "-O -msse -mfpmath=sse" }
> -! { dg-require-effective-target sse }

Again.

> Index: gfortran.dg/pr30667.f
> ===================================================================
> --- gfortran.dg/pr30667.f	(revision 162422)
> +++ gfortran.dg/pr30667.f	(working copy)
> @@ -1,7 +1,6 @@
>  ! { dg-do compile { target i?86-*-* x86_64-*-* } }
>  ! { dg-require-effective-target ilp32 }
>  ! { dg-options "-O2 -msse -ftree-vectorize" }
> -! { dg-require-effective-target sse } 

Again.

Thanks.
	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]