This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Fix violation of self-assignment check in GCC source [4/4]
- From: Richard Guenther <richard dot guenther at gmail dot com>
- To: Le-Chun Wu <lcwu at google dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, rth at redhat dot com, aoliva at redhat dot com
- Date: Thu, 22 Jul 2010 10:30:06 +0200
- Subject: Re: [patch] Fix violation of self-assignment check in GCC source [4/4]
- References: <AANLkTi=DQW1C=7H4k-Tec73z-328qxzSYHGurpjguLzn@mail.gmail.com>
On Thu, Jul 22, 2010 at 3:44 AM, Le-Chun Wu <lcwu@google.com> wrote:
> This patch fix the warning triggered by self-assignment check in
> config/i386/i386.c. (Note that the compiler does not emit bogus
> uninitialized warning on fcode any more so the self-init hack is no
> longer needed.) Bootstrapped and tested on x86_64-gnu-linux. OK for
> trunk?
Hm, that's self-init. Do we now warn for this by default?
Anyway, if there is no longer a bogus warning about unintiialized
use then this patch is ok.
Thanks,
Richard.
> Thanks,
>
> Le-chun
>
> 2010-07-21 ?Le-Chun Wu ?<lcwu@google.com>
>
> ? ? ? * config/i386/i386.c (ix86_vectorize_builtin_vec_perm): Remove
> ? ? ? unnecessary self-init.
>
>
> Index: gcc/config/i386/i386.c
> ===================================================================
> --- gcc/config/i386/i386.c ? ? ?(revision 162385)
> +++ gcc/config/i386/i386.c ? ? ?(working copy)
> @@ -30013,7 +30013,7 @@ ix86_vectorize_builtin_vec_perm (tree ve
> ? tree itype = TREE_TYPE (vec_type);
> ? bool u = TYPE_UNSIGNED (itype);
> ? enum machine_mode vmode = TYPE_MODE (vec_type);
> - ?enum ix86_builtins fcode = fcode; /* Silence bogus warning. ?*/
> + ?enum ix86_builtins fcode;
> ? bool ok = TARGET_SSE2;
>
> ? switch (vmode)
>