This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Fix violation of self-assignment check in GCC source [2/4]
- From: Richard Guenther <richard dot guenther at gmail dot com>
- To: Le-Chun Wu <lcwu at google dot com>
- Cc: Diego Novillo <dnovillo at google dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 22 Jul 2010 10:28:14 +0200
- Subject: Re: [patch] Fix violation of self-assignment check in GCC source [2/4]
- References: <AANLkTi=E23zMuWvPcgqMV=SijW2vH_QGtMuxEZK6PB0g@mail.gmail.com>
On Thu, Jul 22, 2010 at 3:31 AM, Le-Chun Wu <lcwu@google.com> wrote:
> This patch fix the warning triggered by self-assignment check in
> gcc/tree-ssa-ccp.c. Bootstrapped and tested on x86_64-gnu-linux. OK
> for trunk?
Ok.
Thanks,
Richard.
> Thanks,
>
> Le-chun
>
> 2010-07-21 ?Le-Chun Wu ?<lcwu@google.com>
>
> ? ? ? * tree-ssa-ccp.c (ccp_lattice_meet): Remove a self-assign statement
> ? ? ? and an unnecessary assignment.
>
>
>
> Index: gcc/tree-ssa-ccp.c
> ===================================================================
> --- gcc/tree-ssa-ccp.c ?(revision 162385)
> +++ gcc/tree-ssa-ccp.c ?(working copy)
> @@ -730,9 +730,8 @@ ccp_lattice_meet (prop_value_t *val1, pr
> ? ? ? ? Ci M Cj = VARYING ? ? ?if (i != j)
>
> ? ? ? ? ?If these two values come from memory stores, make sure that
> - ? ? ? ?they come from the same memory reference. ?*/
> - ? ? ?val1->lattice_val = CONSTANT;
> - ? ? ?val1->value = val1->value;
> + ? ? ? ?they come from the same memory reference.
> + ? ? ? ? Nothing to do. ?VAL1 already contains the value we want. ?*/
> ? ? }
> ? else
> ? ? {
>