This is the mail archive of the
mailing list for the GCC project.
Re: [patch i386]: Add for win32 targets pre-prologue profiling feature
On 07/15/2010 11:08 AM, Kai Tietz wrote:
> (override_options): Add special handling for -mfentry.
> (ix86_function_regparm): Likewise.
> (ix86_function_sseregparm): Likewise.
Why are you adding the special-casing to the two regparm functions?
You do realize that suddenly your mcount_top function may have zero
free registers with which to do its job. I think that's a bad idea.
No changes? ;-)
x86_function_profiler is broken for -m32 -fentry -fpic. It uses
%ebx which has not been set up. I think perhaps this combination
cannot really be supported, and this should be diagnosed back in
> +@hook TARGET_PROFILE_BEFORE_PROLOGUE
> +It returns true if target wants profile code emitted before
> +The default version of this hook use the target macro
> +@end deftypefn
The text should go in target.def, in the ""; only the @hook line goes here.