This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Conflicting IRA patches


Bernd Schmidt wrote:
On 07/13/2010 05:49 PM, Vladimir Makarov wrote:

I checked Bernd's patch on SPEC2000 on x86 (32-bit modes) last week. Code of few benchmarks changed (only vpr, gcc, crafty, parser, eon,
vortex, mesa, facerec, sixtrack, apsi). The codes size for SPECINT2000
was improved by 0.03% with patch and code size for SPECFP2000 was worsen
by 0.006%. There is no visible improvement/degradation on changed
benchmarks. Compilation time increase was quite insignificant (less than 0.2%). So as I wrote Ken Zadeck two years ago who tried to solve
the problem for the old RA, the complexity of the problem solution does
not justify the solution benefits.

I feel one of the major benefits is enhanced predictability - it becomes easier to tune other code, e.g. to add splitters to help the lower-subreg pass. If IRA is able to handle multiword conflicts more gracefully, it becomes easier to demonstrate that such changes are beneficial since the results are more well-behaved. It would also eliminate most of the need for the clobbers patch I sent earlier today.

Ok. I am not against the patch itself. I still solves some PRs. I just don't like that IRA becomes more complex (that is what I did not like in Ken's patch too). But it seems to me inevitable. It will happen earlier or later.
As for patch priority for checking in, I think you are right especially
if we take that I have a branch for my work and Bernd does not have one
and resolution of the conflicts could be done on ira-improv branch.

Sorry, which priority is right?


Your patch should go first before the major cover class patch. Then I could do conflict resolution with your patch and Richard's one on the branch and resubmit my patches.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]