This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch win32]: Allow exports of def-file reserved keywords as symbol
- From: Dave Korn <dave dot korn dot cygwin at gmail dot com>
- To: Kai Tietz <ktietz70 at googlemail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Dave Korn <dave dot korn dot cygwin at googlemail dot com>, Danny Smith <dannysmith at clear dot net dot nz>
- Date: Sun, 11 Jul 2010 03:42:46 +0100
- Subject: Re: [patch win32]: Allow exports of def-file reserved keywords as symbol
- References: <AANLkTik71uJUnmm4FDaK0ghXOeo_ZfHhZkOpbl91CgI-@mail.gmail.com>
On 10/07/2010 19:54, Kai Tietz wrote:
> this patch fixes a small nit in respect to the dllexport attribute and
> x64 windows without leading underscores. As it is possible now that
> somebody tries to export symbol (for example) named 'data', which is a
> reserved keyword of def-file parser present in ld, the export would
> fail by a linker error. By quoting the symbol name by ', this issue is
> fixed.
>
> ChangeLog
>
> * config/i386/winnt.c (i386_pe_file_end): Quote symbol name
> in directive -export.
>
> I'll apply this patch in a couple of hours, if there are no objections.
Kai will have already received this directly, but for the sake of the
archives and Danny: please see
http://sourceware.org/ml/binutils/2010-07/msg00106.html
cheers,
DaveK