This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFC: [GUPC] UPC-related front-end changes
- From: Tom Tromey <tromey at redhat dot com>
- To: Gary Funck <gary at intrepid dot com>
- Cc: Gcc Patches <gcc-patches at gcc dot gnu dot org>, Joseph Myers <joseph at codesourcery dot com>, Richard Henderson <rth at redhat dot com>
- Date: Thu, 08 Jul 2010 09:06:40 -0600
- Subject: Re: RFC: [GUPC] UPC-related front-end changes
- References: <20100708061704.GA8748@intrepid.com>
>>>>> "Gary" == Gary Funck <gary@intrepid.com> writes:
Hi.
I didn't really read most of the patch, but this bit stood out for me:
Gary> --- gcc/tree.h (.../trunk) (revision 161517)
Gary> +++ gcc/tree.h (.../branches/gupc) (revision 161914)
Gary> @@ -367,6 +367,12 @@ struct GTY(()) tree_base {
Gary> unsigned asm_written_flag: 1;
Gary> unsigned nowarning_flag : 1;
Gary> + /* UPC flags */
Gary> + unsigned shared_flag : 1; /* UPC: shared qualified */
Gary> + unsigned strict_flag : 1; /* UPC: strict qualified */
Gary> + unsigned relaxed_flag : 1; /* UPC: relaxed qualified */
Gary> + unsigned upc_unused : 5; /* UPC: unused bits */
I think it would be better to use some bits from tree_base's "spare"
field and not have "upc_unused" at all. tree_base is size-sensitive.
Tom