This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RS6000] Hookize REGISTER_MOVE_COST and MEMORY_MOVE_COST
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Anatoly Sokolov <aesok at post dot ru>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 8 Jul 2010 10:52:48 -0400
- Subject: Re: [RS6000] Hookize REGISTER_MOVE_COST and MEMORY_MOVE_COST
- References: <143439489.20100708020800@post.ru>
2010/7/7 Anatoly Sokolov <aesok@post.ru>:
> ?Hi.
>
> ?This patch removes obsolete REGISTER_MOVE_COST and MEMORY_MOVE_COST macros
> from the RS6000 back end in the GCC and introduces equivalent
> TARGET_REGISTER_MOVE_COST and TARGET_MEMORY_MOVE_COST target hooks.
>
> ?Regression tested on powerpc64-unknown-linux-gnu.
>
> ?OK to install?
>
> ? ? ? ?* reginfo.h (reg_classes_intersect_p): Change arguments type to
> ? ? ? ?reg_class_t.
> ? ? ? ?* rtl.h (reg_classes_intersect_p): Adjust prototype.
>
> ? ? ? ?* config/rs6000/rs6000.h (REGISTER_MOVE_COST, MEMORY_MOVE_COST):
> ? ? ? ?Remove macros.
> ? ? ? ?* config/rs6000/rs6000-protos.h (rs6000_register_move_cost,
> ? ? ? ?rs6000_memory_move_cost): Remove
> ? ? ? ?* config/rs6000/rs6000.c (TARGET_REGISTER_MOVE_COST,
> ? ? ? ?TARGET_MEMORY_MOVE_COST): Define.
> ? ? ? ?(rs6000_register_move_cost): Make static. Change arguments type from
> ? ? ? ?enum reg_class to reg_class_t. Adjust rs6000_memory_move_cost calls.
> ? ? ? ?(rs6000_memory_move_cost): Make static. Change arguments type from
> ? ? ? ?'enum reg_class' to reg_class_t.
I cannot approve the reginfo.h and rtl.h changes. And shouldn't a
patch convert all of the backends to target hooks, not just rs6000?
Thanks, David