This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: do not include diagnostic-core.h in toplev.h


On Thu, Jul 8, 2010 at 3:33 PM, Richard Earnshaw <rearnsha@arm.com> wrote:
>
> On Thu, 2010-07-08 at 14:03 +0200, Richard Guenther wrote:
>> On Thu, Jul 8, 2010 at 1:30 PM, Ramana Radhakrishnan
>> > /home/ramrad01/sources/trunk/gcc/config/arm/neon.md: In function
>> > 'output_1491':
>> > /home/ramrad01/sources/trunk/gcc/config/arm/neon.md:4306:5: error:
>> > implicit declaration of function
>> > 'error' [-Werror=implicit-function-declaration]
>>
>> Emitting diagnostics from the machine description?! ?The above is
>> the right punishment you deserve for that ;))
>>
>> Consider properly constraining the insns instead.
>
> Bzzt! wrong. ?These come from the machine-dependent intrinsics. ?There's
> no insn constraints involved in that part of the process and the code is
> correctly generating diagnostics when these are misused. ?What else
> should it do?

Shouldn't the machine-dependent builtin expander then do the
verification and diagnostic reporting?

Richard.

> R.
>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]