Re: do not include diagnostic-core.h in toplev.h

[Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>]

> > /home/ramrad01/sources/trunk/gcc/config/arm/neon.md: In function
> > 'output_1491':
> > /home/ramrad01/sources/trunk/gcc/config/arm/neon.md:4306:5: error:
> > implicit declaration of function
> > 'error' [-Werror=implicit-function-declaration]
> 
> Emitting diagnostics from the machine description?!  The above is
> the right punishment you deserve for that ;))

 It's not very simple to fix this up easily because IIUC the way in
which the neon builtins are set up to expand (1870 of them) makes it
slightly hard to check individually and that probably explains the use
for such a large number of them. Someone will need a deeper look into
how to make sure these work correctly post this shakeup.

The number of backends that are using the diagnostics are listed below
for other target maintainers to deal with the fallout in their
respective targets.

A grep finds calls to some diagnostics in other backends and hopefully
someone else will also catch these. error and internal_error seems to be
the only diagnostics being used.


arm/neon.md:    error ("lane out of range");
arm/neon.md:    error ("lane out of range");
arm/neon.md:    error ("lane out of range");
arm/neon.md:    error ("lane out of range");
arm/neon.md:    error ("lane out of range");
arm/neon.md:    error ("lane out of range");
arm/neon.md:    error ("lane out of range");
arm/neon.md:    error ("lane out of range");
arm/neon.md:    error ("lane out of range");
arm/neon.md:    error ("lane out of range");
arm/neon.md:    error ("lane out of range");
arm/neon.md:    error ("lane out of range");
arm/neon.md:    error ("lane out of range");
arm/neon.md:    error ("lane out of range");
arm/neon.md:    error ("lane out of range");
arm/neon.md:    error ("lane out of range");

cris/cris.md:                 internal_error ("expand_binop failed in
movsi gotrel");
cris/cris.md:             internal_error ("expand_binop failed in movsi
got");
cris/cris.md:             internal_error ("expand_binop failed in movsi
got+offs");

mmix/mmix.md:   internal_error (\"MMIX Internal: Bad truncdfsf2
expansion\");
mmix/mmix.md:   internal_error (\"MMIX Internal: Bad extendsfdf2
expansion\");

spu/spu-builtins.md:      error ("spu_convtf expects an integer literal
in the range [0, 127].");
spu/spu-builtins.md:      error ("spu_convts expects an integer literal
in the range [0, 127].");
spu/spu-builtins.md:      error ("spu_convtf expects an integer literal
in the range [0, 127].");
spu/spu-builtins.md:      error ("spu_convtu expects an integer literal
in the range [0, 127].");
stormy16/predicates.md:      error ("constant halfword load operand out
of range");
stormy16/predicates.md:      error ("constant arithmetic operand out of
range");

cheers
Ramana