This is the mail archive of the
mailing list for the GCC project.
Re: [patch i386]: Add support of "hotfix" -feature for x64
On Wed, Jul 7, 2010 at 6:50 AM, Kai Tietz <firstname.lastname@example.org> wrote:
> 2010/7/7 Jack Howarth <email@example.com>:
>> ? While I can test any revised patch you come up with, the changes to
>> gcc/config/darwin.h really needs to be approved by the Darwin maintainer
>> (Mike Stump) before a revised patch is reapplied.
>> ? ? ? ? Jack
> Thanks, and sorry for the troubles.
> I see that I have to guard the default define of
> ASM_DECLARE_FUNCTION_NAME macro in config/ OS headers. This should fix
> the issue. If you could test it for darwin?
> I'll respin the complete patch (with prior i386 parts) then again.
The whole approach looks wrong to me. I think you should
introduce a new macro, ASM_OUTPUT_FUNCTION_LABEL,
which is default to ASM_OUTPUT_LABEL. We replace
ASM_OUTPUT_LABEL with ASM_OUTPUT_FUNCTION_LABEL
in ASM_DECLARE_FUNCTION_NAME. You can override
ASM_OUTPUT_FUNCTION_LABEL in x86 to generate
what you need.