This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [x86] Implement static static checking


> Can you please also create testcase(s) that exercise new option?

The testcases are gnat.dg/stack_check1.adb and gnat.dg/stack_check2.adb and 
the 6 ACATS testcases listed in ada/acats/stackcheck.lst; they all pass.

> No need for explicit <P:...> in the insn name, since only one mode
> iterator is used (perhaps you should also add an underscore before the
> mode?)

I can remove the <P:...> (although this is less clear in my opinion) but the 
mode is usually not separated by an underscore in pattern names.

> Please implement this (and similar probe_stack_range{si,di} calls) by
> initializing static function pointer in the way ix86_gen_leave and Co.
> are implemented.

OK, will fix.

-- 
Eric Botcazou


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]