This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch i386]: Add support of "hotfix" -feature for x64

On Wed, Jul 07, 2010 at 09:15:45AM +0200, Kai Tietz wrote:
> this is the more improved patch, which handles for Wine linux the
> hotfix part via ASM_DECLARE_FUNCTION_NAME, too.

This is very ugly.  An OS isn't a subtarget of any kind.
If this is really the way to go, use ASM_DECLARE_OS_FUNCTION_NAME
or something similar.

BTW,

  bool is_ms_hook = ((decl && ix86_function_ms_hook_prologue (decl)) ? true
                                                                     : false);

is horribly ugly.  You should just use

  bool is_ms_hook = decl && ix86_function_ms_hook_prologue (decl);

	Jakub
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]