This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch i386]: Add support of "hotfix" -feature for x64
On Tue, Jul 6, 2010 at 4:26 PM, Jack Howarth <howarth@bromo.med.uc.edu> wrote:
> On Tue, Jul 06, 2010 at 08:28:48PM +0200, Kai Tietz wrote:
>> 2010/7/6 Uros Bizjak <ubizjak@gmail.com>:
>> > Hello!
>> >
>> >> Better, but honestly I'd been thinking just to bring one
>> >> directive per line, rather than trying to block the output
>> >> onto several lines. ?I.e.
>> >>
>> >> ? for (i = 0; i < filler_count; i += 4)
>> >> ? ?fprintf (asm_out_file, ASM_LONG " 0x%x\n", filler_cc);
>> >>
>> >>
>> >> Ok with that change.
>> >
>> > Please also use %#x instead of 0x%x.
>> >
>> > Thanks,
>> > Uros.
>> >
>>
>>
>> Ok, changed it to a simple loop without formatting and I use %#x.
>> Committed at revision 161875 & 161876
>>
>> Thanks,
>> Kai
>
> This patch breaks the bootstrap on i386-apple-darwin* and
> x86_64-apple-darwin* since gcc/config/darwin.h defines
> ASM_DECLARE_FUNCTION_NAME(FILE, NAME, DECL). Simply changing...
>
This may also cause:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44850
--
H.J.