This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch i386]: Add support of "hotfix" -feature for x64
- From: Richard Henderson <rth at redhat dot com>
- To: Kai Tietz <ktietz70 at googlemail dot com>
- Cc: Kai Tietz <Kai dot Tietz at onevision dot com>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 06 Jul 2010 09:12:12 -0700
- Subject: Re: [patch i386]: Add support of "hotfix" -feature for x64
- References: <OF8699C863.A8A79154-ONC1257752.00406953-C1257752.0041CC76@onevision.de> <4C2E26A6.4020002@redhat.com> <AANLkTin48nulplMh1JLXU2ypA1cevrinA4y_0pd2DRh4@mail.gmail.com>
On 07/03/2010 02:05 AM, Kai Tietz wrote:
>> The double loop overcomplicates things. I think you're better off
>> with just a plain for-loop.
+ for (; filler_count > 0;)
+ {
+ if ((filler_count & 15) == 0)
+ fprintf (asm_out_file, ASM_LONG " 0x%x", filler_cc);
+ else
+ fprintf (asm_out_file, ", 0x%x", filler_cc);
+ filler_count -= 4;
+ if ((filler_count & 15) == 0)
+ fprintf (asm_out_file, "\n");
+ }
Better, but honestly I'd been thinking just to bring one
directive per line, rather than trying to block the output
onto several lines. I.e.
for (i = 0; i < filler_count; i += 4)
fprintf (asm_out_file, ASM_LONG " 0x%x\n", filler_cc);
Ok with that change.
r~