This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [1/3] optabs: introduce {SET_,}{CONVERT_,}OPTAB_HANDLER
On Sat, Jul 3, 2010 at 10:38 PM, Diego Novillo <dnovillo@google.com> wrote:
> On Saturday, July 3, 2010, Richard Sandiford <rdsandiford@googlemail.com> wrote:
>
>> I wondered about that, and not having a strong feeling either way,
>> decided to stick with the current macro idiom. ?Can change if you like.
>
> Yes, please. ?I would like to eliminate most of the function-like
> macros we have. ?Let the inliner do its job and improve debuggability
> by being able to set proper breakpoints.
... and force us to include headers that exposes things that should
not be exposed. See e.g. all GIMPLE static inlines, which force us to
expose the GIMPLE data structures also. And here the obtabs internals
to files that only use obtabs.
I'm not as big a fan of static inline functions for this reason.
Ciao!
Steven