This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [build, libjava] Support Sun symbol versioning in libjava


On 07/01/2010 05:04 PM, Rainer Orth wrote:
> [Please keep me on the Cc:, I'm not subscribed to java-patches.  Thanks.]
> 
> After the precedent established by the patch to support Sun symbol
> versioning in libstdc++
> 
> 	PATCH: Support Sun symbol versioning in libstdc++-v3
>         http://gcc.gnu.org/ml/gcc-patches/2010-02/msg01001.html
> 
> and its revision
> 
> 	[build, doc, v3] Support Sun symbol versioning in libstdc++-v3, rev. 2
>         http://gcc.gnu.org/ml/gcc-patches/2010-06/msg03182.html
> 
> libjava appeared relatively easy at first:

To begin with, your patch was *below* the .sig delimiter.  People won't
see it there.

I have to admit I don't understand many of the issues here.  There seem
to be many changes to the Linux version, which I don't see the need for.

Did you test this on GNU/Linux ?

> Besides, there are a couple of other shared libraries installed by
> libjava, which may be internal implementation details and not usable by
> end users.  Perhaps they should be installed into $pkglibdir instead?
> Currently, this affects libgij, libgcj-tools, libjvm, lib-gnu-awt-xlib,
> and libgcj_bc.  The maintainers should be able to easily decide where
> this might apply.

A couple of these are internal, but most not.

Andrew.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]