This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][C++] mem-ref2 merge, C++ gimplification change


On Mon, 28 Jun 2010, Jason Merrill wrote:

> On 06/28/2010 07:14 AM, Richard Guenther wrote:
> > +	else if ((is_gimple_lvalue (op1) || INDIRECT_REF_P (op1))
> 
> is_gimple_lvalue returns true for INDIRECT_REF, you don't need to check
> INDIRECT_REF_P as well.  OK with that change.

It doesn't.  INDIRECT_REF isn't a valid gimple lvalue on the branch,
but you still see it here due to the call half-way inbetween
gimplifying.

Richard.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]