This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: PR44566: accessor macros (2/3): machine_function
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Joern Rennecke <amylaar at spamcop dot net>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 24 Jun 2010 11:28:17 +0000 (UTC)
- Subject: Re: RFA: PR44566: accessor macros (2/3): machine_function
- References: <20100624064359.hs9ji2d0gkwg4w0s-nzlynne@webmail.spamcop.net>
I see nothing in this patch that defines EXTRA_TARGET, which would
indicate that the #ifdef EXTRA_TARGET stanza doesn't belong here.
You should use @code{MACHINE_FUNCTION (@var{function})} in tm.texi.
I think some people have expressed a dislike of svn:mergeinfo properties
referencing random branches being added to trunk. (Your patch has:
Property changes on: gcc/config
___________________________________________________________________
Added: svn:mergeinfo
Merged /branches/multi-target-20100613-branch/gcc/config:r160896
)
You should create target-gtypes.h under a temporary name, then rename it
once finished to the final target-gtypes.h name using move-if-change,
together with the use of a timestamp file as done for other such generated
files.
--
Joseph S. Myers
joseph@codesourcery.com