Re: PR43902 patch: Widening multiply-accumulate

[Bernd Schmidt <bernds at codesourcery dot com>]

On 06/23/2010 11:26 AM, Richard Guenther wrote:

> So it computes (op0 * op1) +- op2?  Please adjust the comment
> to say which operands are multiplied and which is added/subtracted.

Done.

> So this restricts this to integral or fixed-point types.  Can you
> document it as such in the comment in tree.def?

Done.  I've also removed the last test for vector types here; this can
be re-added later if the vectorizer decides it wants to use these tree
codes.

> Your support for ternary gimple is far from complete - I'm not sure
> we want to have this half-supported state (though I guess I don't
> care too much and definitely like that we start on it rather than
> using more single rhss).

I'm thinking it makes little sense to try to convert other passes if
there is no way at the moment to test these modifications.

> Can you adjust gimple.texi for the new RHS type?

Done.

I've also added another ARM testcase.


Bernd

Attachment: widenmacc-v4.diff
Description: Text document