This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: trunk patch: moving gimple_seq_node from coretypes.h to gimple.h


On Tue, Jun 22, 2010 at 8:30 PM, Basile Starynkevitch
<basile@starynkevitch.net> wrote:
> Hello All,
>
> since gimple_seq_node is not very useful in coretypes.h I bootstrapped
> the following attached patch to trunk rev.161214 on
> x86_64-unknown-linux-gnu with c,c++,lto languages.
>
> gcc/ChangeLog entry:
>
> 2010-06-22 ?Basile Starynkevitch ?<basile@starynkevitch.net>
> ? ? ? ?* coretypes.h (gimple_seq_node_d, gimple_seq_node)
> ? ? ? ?(const_gimple_seq_node): Removed typedefs.
>
> ? ? ? ?* gimple.h ?(gimple_seq_node_d, gimple_seq_node)
> ? ? ? ?(const_gimple_seq_node): Added typedefs moved from coretypes.h.

Please do not do this. gimple_seq is used in target.h for example, but
target.h should not have to include gimple.h.

This patch is a step in the wrong direction.

Ciao!
Steven


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]