This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Patch 8/9: track live ranges for objects

From: Jeff Law <law at redhat dot com>
To: Bernd Schmidt <bernds at codesourcery dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 18 Jun 2010 14:12:36 -0600
Subject: Re: Patch 8/9: track live ranges for objects
References: <4C1B7BC0.7010803@codesourcery.com> <4C1B7E81.2030900@codesourcery.com>

On 06/18/10 08:11, Bernd Schmidt wrote:

Just a couple nits I noticed in ira-int.h:

  /* Pointer to structures describing at what program point the
+     object lives.  We always maintain the list in such way that *the
+     ranges in the list are not intersected and ordered by decreasing
+     their program points*.  */

Note the "points*" and "*the". Looks like a nit you copied from the comment for live_ranges. Please fix at your leisure.

The patch itself is fine,

Thanks,
Jeff

References:
- Patch 0/9: IRA cleanups and preparations for tracking subwords of DImode
  - From: Bernd Schmidt
- Patch 8/9: track live ranges for objects
  - From: Bernd Schmidt

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]