This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ reload-v2]


>>
>>> ggc_realloc is no longer supported, ggc_realloc_stat is the proper way
>>> to do things now.   This allows reload-v2 to bootstrap after monday's
>>> merge from the trunk.
>>>      
>> Well, it was definitly not intention of my statistics code to require
>> users to add random PASS_MEM_STAT.
>> There should be always corresponding macro hidding that.
>>    
> OK.  I just found another ggc_realloc call and copied what it did.

Well, it is because it was inside _stat function.
those gets MEM_STAT_DECL that compiles to nothing unless you do detailed
mem stats and then it is source file and line, submitted by MEM_STAT_INFO.
However for some functions (like vec_reallocate) we don't want to record
the function itself and rather its callers, so then you create _stat
version of it getting MEM_STAT_DECL and use PASS_MEM_STAT to pass the info
further.

Honza
>
>> Also your patch will not compile with --enable-gather-detailed-stats
>> since you need MEM_STAT_INFO.
>>    
> I'll take care of this.
>
>
> Thanks,
> Jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]