This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Followup for reg_equiv_invariant patch: Fix PR39871

From: Joern Rennecke <amylaar at spamcop dot net>
To: Paolo Bonzini <bonzini at gnu dot org>
Cc: Bernd Schmidt <bernds at codesourcery dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Tue, 15 Jun 2010 06:50:27 -0400
Subject: Re: Followup for reg_equiv_invariant patch: Fix PR39871
References: <4C16B0B4.6080604@codesourcery.com> <4C1749EC.9070006@gnu.org>

Quoting Paolo Bonzini <bonzini@gnu.org>:

+	  if (! CONSTANT_P (x)
 	      || ! flag_pic
 	      /* A function invariant is often CONSTANT_P but may
 		 include a register.  We promise to only pass CONSTANT_P
 		 objects to LEGITIMATE_PIC_OPERAND_P.  */
-	      || (CONSTANT_P (x)&&  LEGITIMATE_PIC_OPERAND_P (x)))
+	      || LEGITIMATE_PIC_OPERAND_P (x))


... and this comment becomes out-of-date as there's no reference
anymore to function_invariant_p in the code.


It becomes more relevant because the note likely contains an invariant
tested before with function_invariant_p.

References:
- Followup for reg_equiv_invariant patch: Fix PR39871
  - From: Bernd Schmidt
- Re: Followup for reg_equiv_invariant patch: Fix PR39871
  - From: Paolo Bonzini

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]