This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Make gimple.h checks conditional with ENABLE_GIMPLE_CHECKING

From: Paolo Bonzini <bonzini at gnu dot org>
To: Jan Hubicka <hubicka at ucw dot cz>
Cc: gcc-patches at gcc dot gnu dot org, rguenther at suse dot de, Laurynas Biveinis <laurynas dot biveinis at gmail dot com>
Date: Wed, 09 Jun 2010 11:50:30 +0200
Subject: Re: Make gimple.h checks conditional with ENABLE_GIMPLE_CHECKING
References: <20100608225711.GA15770@kam.mff.cuni.cz>

On 06/09/2010 12:57 AM, Jan Hubicka wrote:

Hi,
this patch conditionalize the sanity checks in gimple accessor functions.
I originally intended to go through my list of most frequent aborts remianing
in the code, but it seems now to me that it would cause just maintenance
problems since it would be difficult to decide what to check and what not.

The nature of the checks is very similar to the tree/rtl and gimple checking
so I think we should just handle them same way and put them all into
ENABLE_GIMPLE_CHECKING

Bootstrapped/regtested x86_64-linux.  My build time test actually regressed
to 11m16s (it used to be 10m19s), but I am quite convinced it is due to
merge of df-improv branch
OK?

Laurynas, can you check? I understood the gc-improv branch was basically just cleanup, instead Jan's numbers say we're regressing 10%?

Paolo

Follow-Ups:
- Re: Make gimple.h checks conditional with ENABLE_GIMPLE_CHECKING
  - From: Laurynas Biveinis

References:
- Make gimple.h checks conditional with ENABLE_GIMPLE_CHECKING
  - From: Jan Hubicka

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]