Re: [PING,BACKPORT4.5] Re: [PATCH] Fix bootstrap on cygwin

[Dave Korn <dave dot korn dot cygwin at gmail dot com>]

On 08/06/2010 23:40, Steven Bosscher wrote:
> On Wed, Jun 9, 2010 at 12:55 AM, Dave Korn <dave.korn.cygwin@gmail.com>
> wrote:
> 
>>> gcc/ChangeLog:
>>> 
>>> * opts-common.c (prune_options): Ensure replacement argv array is
>>> correctly terminated by a NULL entry.
>>> 
>> PING.  Also, this bug is extant on 4.5 branch as of r.160379, so OK to
>> backport?
> 
> Isn't this obvious?

  I don't think the "obvious" (aka "free for all") rules cover changes to code
(that you didn't check in yourself); svnwrite.html says:

> The following changes can be made by everyone with SVN write access:

> Fixes for obvious typos in ChangeLog files, docs, web pages, comments and
> similar stuff. [ ... ]

> Similarly, no outside approval is needed to revert a patch that you checked
> in.

> Importing files maintained outside the tree from their official versions.

> Creating and using a branch for development [ ... ]

  To my way of thinking, it is no coincidence that "ChangeLog files, docs, web
pages, comments" doesn't mention anything that would indicate it's ok to
change actual functional source code.  It mentions "obvious typos", but not
"obvious bugfixes".  I'm pretty sure I need approval.

    cheers,
      DaveK