This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix code size estimates wrt variadic functions
On Tue, Jun 1, 2010 at 7:57 AM, Nathan Froyd <froydnj@codesourcery.com> wrote:
> On Tue, Jun 01, 2010 at 10:22:51AM +0200, Steven Bosscher wrote:
>> On Tue, Jun 1, 2010 at 2:02 AM, Jan Hubicka <hubicka@ucw.cz> wrote:
>> > - ? ? ? else if (funtype && prototype_p (funtype))
>> > + ? ? ? else if (funtype && prototype_p (funtype) && !stdarg)
>> > ? ? ? ? ?{
>> > ? ? ? ? ? ?tree t;
>> > ? ? ? ? ? ?for (t = TYPE_ARG_TYPES (funtype); t && t != void_list_node;
>>
>> While you're hacking here... FOREACH_FUNCTION_ARGS?
>
> Unfortunately FOREACH_FUNCTION_ARGS is not quite right because it does
> not do checking for void_list_node. ?You can, of course, check for
> void_list_node in the loop (I think I have done this in one of my recent
> Java patches), but that is not so nice from an abstraction point of view.
>
> -Nathan
>
What's the status on this patch?